Merge branch 'main' into fix_985_986

Author: h-hirokawa

.github/workflows/check_label.yml

@@ -1,5 +1,5 @@
 ---
-name: "Check label"
+name: "Check PR label 👓"
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
   cancel-in-progress: true

.github/workflows/codecoverage.yml

@@ -1,5 +1,5 @@
 ---
-name: "Code coverage"
+name: "Code Coverage 🎯"
 
 on:  # yamllint disable-line rule:truthy
   push:

.github/workflows/integration-libssh.yml

@@ -0,0 +1,44 @@
+---
+name: Integration tests 💻
+on:
+  pull_request_target:
+    branches: [main]
+    types:
+      - labeled
+      - opened
+      - reopened
+      - synchronize
+    paths:
+      - "plugins/**"
+      - "tests/integration/**"
+  workflow_dispatch:
+jobs:
+  lab-create:
+    uses: ansible/ansible-content-actions/.github/workflows/cml_lab_create.yaml@main
+    with:
+      topology_path: tests/integration/labs/multi.yaml
+      # lab_title_override: "Optional custom lab title"
+    secrets:
+      virl_host: ${{ secrets.VIRL_HOST }}
+      virl_username: ${{ secrets.VIRL_USERNAME }}
+      virl_password: ${{ secrets.VIRL_PASSWORD }}
+
+  integration-tests:
+    needs: lab-create
+    strategy:
+      fail-fast: true
+      matrix:
+        ansible_version: ["stable-2.16", "stable-2.18", "stable-2.19", "milestone", "devel"]
+    uses: ansible/ansible-content-actions/.github/workflows/cml_network_integration.yaml@main
+    with:
+      ansible_version: ${{ matrix.ansible_version }}
+      lab_nodes: ${{ needs.lab-create.outputs.lab_nodes_json }}
+
+  lab-destroy:
+    if: ${{ always() }}
+    needs: integration-tests
+    uses: ansible/ansible-content-actions/.github/workflows/cml_lab_destroy.yaml@main
+    secrets:
+      virl_host: ${{ secrets.VIRL_HOST }}
+      virl_username: ${{ secrets.VIRL_USERNAME }}
+      virl_password: ${{ secrets.VIRL_PASSWORD }}

.github/workflows/integration-test.yml

@@ -1,4 +1,4 @@
-name: Integration
+name: "Integration - old"
 on:
   pull_request_target:
     branches: [main]

.github/workflows/release.yml

@@ -1,5 +1,5 @@
 ---
-name: "Release collection"
+name: "Release collection 🚀"
 on:  # yamllint disable-line rule:truthy
   release:
     types: [published]

.github/workflows/tests.yml

@@ -1,5 +1,5 @@
 ---
-name: "CI"
+name: "Collection Tests 🧪"
 
 concurrency:
   group: ${{ github.head_ref || github.run_id }}

.pre-commit-config.yaml

@@ -6,13 +6,14 @@ ci:
   autofix_commit_msg: "chore: auto fixes from pre-commit.com hooks"
 
 repos:
+  # not a permanent fix, but to hardcode ansible-core 2.16 as repo dependecy
   - repo: https://github.com/ansible-network/collection_prep
-    rev: 1.1.2
+    rev: da78082ea59b03ad16cd7dbee267f53e8ff50bb5
     hooks:
       - id: update-docs
 
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v5.0.0
+    rev: v6.0.0
     hooks:
       - id: check-merge-conflict
       - id: check-symlinks

README.md

@@ -6,8 +6,7 @@ The Ansible Cisco NX-OS collection includes a variety of Ansible content to help
 
 The Cisco NX-OS connection plugins combined with Cisco NX-OS resource modules aligns the Cisco NX-OS experience with the other core networking platforms supported by Ansible.
 
-This collection has been tested against Cisco N9K-C9300v chassis running NX-OS 9.3.6.
-The modules with full support for Cisco MDS are tested against NX-OS 8.4(1) on MDS Switches.
+The modules with full support for Cisco MDS are tested against NX-OS 8.4(1) and 9.4(3a) on MDS Switches. The modules should work for all releases above 8.4(1)
 
 ## Support
 

changelogs/fragments/fix_santiy_220.yaml

@@ -0,0 +1,5 @@
+---
+trivial:
+  - Fix sanity issues and remove old python 2.x imports and dependencies.
+  - Fix lint issues for lab files for CML based integration testing.
+  - Update github workflow names for better clarity.

changelogs/fragments/update_main_readme.yaml

@@ -0,0 +1,3 @@
+---
+doc_changes:
+  - Update support statement for the collection in README.md for MDS switches.