View media artifacts with browser instead of Code component #10809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
force-pushed
the
test-images
branch
9 times, most recently
from
96be8d4 to
a0765be
Compare
fmeum
approved these changes
Dec 2, 2025
bduffany
force-pushed
the
test-images
branch
2 times, most recently
from
86e96fd to
c2444dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a target artifact has a recognized media extension like
.pngor.webm, then when clicking the "View" link, open the file in the browser (in a new tab) instead of the Code component, which currently shows a bunch of binary data.Working towards improving the UX a little bit for webdriver tests, which produce image and video artifacts: https://buildbuddy-corp.slack.com/archives/C04S4M5U3BK/p1763512291359519
Also tweak the icon styling of the "View" icon a bit. The current icon looks grayed out and not super clickable.
Before:
After: