Skip to content

Conversation

@jaimergp
Copy link
Member

PR Checklist:

  • note any issues closed by this PR with closing keywords
  • if you are adding a new page under docs/ or community/, you have added it to the sidebar in the corresponding _sidebar.json file
  • put any other relevant information below

Needed by #2661, #2660 and others to come.

@jaimergp jaimergp requested a review from a team as a code owner November 21, 2025 16:17
@netlify
Copy link

netlify bot commented Nov 21, 2025

Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit 39e3e6c
🔍 Latest deploy log https://app.netlify.com/projects/conda-forge-previews/deploys/6932b1c41f24100008703d55
😎 Deploy Preview https://deploy-preview-2663--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 66
Accessibility: 96
Best Practices: 100
SEO: 89
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment on lines 33 to 34
3. Pull from upstream: `git pull upstream main`.
- If this results in merge conflicts, abort with `git merge --abort` and hard-reset `main`. This WILL lose all the changes made in `main` that were not part of upstream. The command is: `git reset --hard upstream/main`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps that's not the right change to discuss this, but perhaps it would be more helpful to suggest:

git pull --rebase ...

This will also be the less nuclear option than hard reset.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can easily describe this in ways that doesn't lose work. For example:

git fetch upstream
git merge upstream/main
# in case of conflicts
git merge --abort
git checkout -b separate_branch_to_park_changes
git checkout main
git reset --hard upstream/main

And then we can also describe how to rebase the branch (which is often the cause of the conflicts due to rerender commits):

git checkout separate_branch_to_park_changes
# an "interactive" rebase, hence -i; ensure you did `git fetch upstream` before
git rebase -i upstream/main
# remove unwanted commits from rebase TODO file that should open, especially rerenders; then save and exit
# git will then replay your commits on top of the main branch; for any conflict, decide between:
#  * fixing it, then `git add .` & `git commit ...` & `git rebase --continue`
#  * skipping the commit `git rebase --skip`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check 244a23f

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that basically a very roundabout way of git pull --rebase, though? I mean, besides using a separate branch.

jaimergp and others added 2 commits December 1, 2025 15:39
Co-authored-by: Michał Górny <mgorny@gentoo.org>
@jaimergp jaimergp requested a review from h-vetinari December 2, 2025 09:40
@jaimergp
Copy link
Member Author

jaimergp commented Dec 2, 2025

@h-vetinari, can you take another look / approve? This one is needed in the other PRs because otherwise Docusaurus will complain about a missing doc.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two nits

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed the click on the second one before...

Co-authored-by: h-vetinari <h.vetinari@gmx.com>
@jaimergp
Copy link
Member Author

jaimergp commented Dec 3, 2025

Applied, @h-vetinari. PTAL 🙏

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more thing that doesn't make sense IMO

Co-authored-by: h-vetinari <h.vetinari@gmx.com>
Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one last nit. Thanks for the patience on this

Co-authored-by: h-vetinari <h.vetinari@gmx.com>
@jaimergp jaimergp enabled auto-merge (squash) December 5, 2025 10:20
@jaimergp jaimergp disabled auto-merge December 5, 2025 10:34
@jaimergp jaimergp merged commit 7efa299 into conda-forge:main Dec 5, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants