Skip to content

Conversation

@purnimagarg1
Copy link
Collaborator

Linear ticket:
https://linear.app/acryl-data/issue/CAT-1004/implement-search-by-source-name-on-select-source-screen

Description:

Add search on source selection screen of create source flow. Also, use a single sources.json file

Screenshots:

image image

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Dec 5, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 5, 2025
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Dec 5, 2025

✅ Meticulous spotted 0 visual differences across 987 screens tested: view results.

Meticulous evaluated ~8 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit 763c812. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Dec 5, 2025

Bundle Report

Changes will decrease total bundle size by 31.71kB (-0.11%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.74MB -31.71kB (-0.11%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -31.71kB 19.11MB -0.17%

Files in assets/index-*.js:

  • ./src/app/ingestV2/source/builder/sources.json → Total Size: 36.8kB

  • ./src/app/ingestV2/source/multiStepBuilder/steps/step1SelectSource/EmptySearchResults.tsx → Total Size: 451 bytes

  • ./src/app/ingestV2/source/multiStepBuilder/steps/step1SelectSource/SelectSourceStep.tsx → Total Size: 4.39kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants