feat(ingestion/grafana) add option to pass grafana user email as dashboard owner #15489
+31
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
daha
changed the title
daha
changed the title
daha
force-pushed
the
source-grafana-dashboard-owner-improvement
branch
from
01071c7 to
26e9217
Compare
datahub-cyborg
bot
added
the
needs-review
…board owner Also remove the unique id of the dashboard as a owner.
daha
force-pushed
the
source-grafana-dashboard-owner-improvement
branch
from
26e9217 to
5964397
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR add a option like for the looker source to use the user email for the corpuser URN or just the part before @. Default to the part before @ as that is the behavior before this change.
Also so not add the unique dashboard id as a dashboard owner. I really do not understand why that was added in the first place. If someone really need it, it can be added by a transformer as the dashboard id is part of the dashboard URN.