Skip to content

Conversation

@FalkWoldmann
Copy link

Description
Right now, we always use once_cell in naga, even when std with LazyLock` is available.

Testing
I ran cargo xtask test locally.

Squash or Rebase?

Rebase

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@FalkWoldmann
Copy link
Author

The "cleanest" way of ensuring that once_lock is actually optional for std builds would be to introduce an explicit std feature. This would, however, mean breaking changes for no_std users, as they would then need to add naga with no default features and the once_cell feature. Would this be okay with you?

@cwfitzgerald cwfitzgerald mentioned this pull request Dec 4, 2025
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant