F #6
Draft
F #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log ARQC command and sanitize dump filenames
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new rich CLI interface for contactless card reading functionality and includes improvements to the underlying NFC extraction logic. The main purpose is to provide a user-friendly terminal interface for EMV card operations with enhanced logging capabilities.
Key changes include:
- Creation of a new rich CLI application with interactive menus and configuration management
- Enhanced function signatures to return APDU commands alongside responses for better logging
- Addition of comprehensive EMV flow documentation
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rich_cli.py | New CLI application with Rich library for interactive card reading and configuration |
| extrair_nfc_limpo.py | Enhanced PDOL parsing, improved function signatures, and better variable naming |
| extrair_nfc.py | Updated function calls to match new signatures from extrair_nfc_limpo.py |
| docs/fluxos_emv.md | New documentation explaining EMV transaction flows and protocols |
| config.json | Default configuration file for the CLI application |
| .github/workflows/pylint.yml | Removed GitHub Actions workflow file |
| if not os.path.exists('dumps'): | ||
| os.makedirs('dumps') | ||
| filename = f"{track2 or 'notrack2'}_{aid}.json" | ||
| filename = f"{track2_prefix}_{aid}.json" |
There was a problem hiding this comment.
The variable track2_prefix is used but not defined in this function. It should be defined based on track2 data similar to the implementation in extrair_nfc_limpo.py.
[WIP] Fix typo in error message handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
F