fix: make updater work with private repos #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, first of all: great repos - both ChatGPT and this one!
I noticed small issue with
updaterscript when using it with private repos. Namely, it produces "Not Found" signatures, e.g.The issue turned out to be using
browser_download_urlto fetch signature. Even when I passed token in headers, it still wouldn't find the file.It can be solved by using GitHub API url:
https://api.github.com/repos/${owner}/${repo}/releases/assets/${assetId}Also, I got some TypeScript issues when cloned the repo, so I fixed those as well.
Cheers