Skip to content

Commit 1ab0675

Browse files
danmarshalldanmarshall
authored
A11y updates (#742)
* lighter breadcrumb background * use higher contrast hljs stylesheet * Add role attribute to tree items for improved accessibility * move role=tablist to parent of tabs * Add language attribute to HTML tag for improved accessibility
1 parent 628e306 commit 1ab0675

File tree

8 files changed

+17
-17
lines changed

8 files changed

+17
-17
lines changed

‎docs/_layouts/api.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
{% assign tree_url = site.baseurl | append: "/docs/" | append : tree[0] | append: "/v3/api/" %}
2222

23-
<li class="c-tree__item o-list-bare__item">
23+
<li class="c-tree__item o-list-bare__item" role="treeitem">
2424
<div class="c-tree__toggle js-tree-toggle{% if page_url == tree_url %} is-open is-active{% endif %}">
2525
<a href="{{ tree_url }}" {% if page_url == tree_url %}class="is-active"{% endif %}>
2626
{{ tree[0] }}

‎docs/_layouts/docs.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<div class="o-layout__item u-1/4@tablet c-tree-stick">
2525
<ul id="site-tree" class="c-tree o-list-bare" role="tree">
2626
{% for tree in site.data.tree %}
27-
<li class="c-tree__item o-list-bare__item">
27+
<li class="c-tree__item o-list-bare__item" role="treeitem">
2828
<div class="c-tree__toggle js-tree-toggle">
2929
{{ tree[0] }}
3030
</div>

‎docs/_sass/settings/_settings.colors.scss‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1308,7 +1308,7 @@ $ms-gray: (
13081308

13091309
/// @group Black
13101310
/// @type Color
1311-
$ms-black-100: #f2f2f2;
1311+
$ms-black-100: #f5f5f5;
13121312

13131313
/// @group Black
13141314
/// @type Color

‎docs/app/js/sanddance-app.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56437,10 +56437,10 @@ function Sidebar(props) {
5643756437
}, (0, _base.base).react.createElement("div", {
5643856438
className: "sidebar-content"
5643956439
}, (0, _base.base).react.createElement((0, _dataScope.DataScope), Object.assign({}, props.dataScopeProps)), (0, _base.base).react.createElement("div", {
56440-
className: "vbuttons",
56441-
role: 'tablist'
56440+
className: "vbuttons"
5644256441
}, (0, _base.base).react.createElement("div", {
56443-
className: "sidebar-dialogs"
56442+
className: "sidebar-dialogs",
56443+
role: 'tablist'
5644456444
}, sidebuttons.map((sidebutton, i)=>(0, _base.base).react.createElement((0, _sideButton.Sidebutton), Object.assign({
5644556445
key: i
5644656446
}, props, sidebutton, {

‎docs/dist/sanddance-explorer/v4/sanddance-explorer.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47152,10 +47152,10 @@ function $a4defabaac4a9afe$export$1ba59dacbcbf90fe(props) {
4715247152
}, (0, $a601a4135959dcb0$export$e2253033e6e1df16).react.createElement("div", {
4715347153
className: "sidebar-content"
4715447154
}, (0, $a601a4135959dcb0$export$e2253033e6e1df16).react.createElement((0, $86b892255d8eb4f0$export$3fb74a6ae4f1171d), Object.assign({}, props.dataScopeProps)), (0, $a601a4135959dcb0$export$e2253033e6e1df16).react.createElement("div", {
47155-
className: "vbuttons",
47156-
role: 'tablist'
47155+
className: "vbuttons"
4715747156
}, (0, $a601a4135959dcb0$export$e2253033e6e1df16).react.createElement("div", {
47158-
className: "sidebar-dialogs"
47157+
className: "sidebar-dialogs",
47158+
role: 'tablist'
4715947159
}, sidebuttons.map((sidebutton, i)=>(0, $a601a4135959dcb0$export$e2253033e6e1df16).react.createElement((0, $d7542c73853af2f5$export$a8fc19311f33df91), Object.assign({
4716047160
key: i
4716147161
}, props, sidebutton, {

‎docs/tests/data-inference/v1/index.html‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
<!DOCTYPE html>
2-
<html>
2+
<html lang="en">
33

44
<head>
55
<meta charset="utf-8" />
66
<meta http-equiv="X-UA-Compatible" content="IE=edge">
77
<title>Data-Inference test</title>
88
<meta name="viewport" content="width=device-width, initial-scale=1">
99
<script src="https://unpkg.com/vega@^5.30/build/vega.js" charset="utf-8"></script>
10-
<link rel="stylesheet" href="https://unpkg.com/@highlightjs/cdn-assets@11.7.0/styles/default.min.css">
11-
<script src="https://unpkg.com/@highlightjs/cdn-assets@11.7.0/highlight.min.js"></script>
10+
<link rel="stylesheet" href="https://unpkg.com/@highlightjs/cdn-assets@11.11.0/styles/a11y-light.css">
11+
<script src="https://unpkg.com/@highlightjs/cdn-assets@11.11.0/highlight.min.js"></script>
1212
<script src="js/data-inference.js"></script>
1313

1414
<style>

‎docs/tests/v4/es6/js/sanddance-app.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56437,10 +56437,10 @@ function Sidebar(props) {
5643756437
}, (0, _base.base).react.createElement("div", {
5643856438
className: "sidebar-content"
5643956439
}, (0, _base.base).react.createElement((0, _dataScope.DataScope), Object.assign({}, props.dataScopeProps)), (0, _base.base).react.createElement("div", {
56440-
className: "vbuttons",
56441-
role: 'tablist'
56440+
className: "vbuttons"
5644256441
}, (0, _base.base).react.createElement("div", {
56443-
className: "sidebar-dialogs"
56442+
className: "sidebar-dialogs",
56443+
role: 'tablist'
5644456444
}, sidebuttons.map((sidebutton, i)=>(0, _base.base).react.createElement((0, _sideButton.Sidebutton), Object.assign({
5644556445
key: i
5644656446
}, props, sidebutton, {

‎packages/sanddance-explorer/src/controls/sidebar.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ export function Sidebar(props: Props) {
7070
<DataScope
7171
{...props.dataScopeProps}
7272
/>
73-
<div className="vbuttons" role='tablist'>
74-
<div className="sidebar-dialogs">
73+
<div className="vbuttons">
74+
<div className="sidebar-dialogs" role='tablist'>
7575
{sidebuttons.map((sidebutton, i) => (
7676
<Sidebutton
7777
key={i}

0 commit comments

Comments
 (0)