-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Description
Acknowledgement
- I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion.
Comment
Consider deprecating <prefix> type assertions
Background
TypeScript has two syntax forms to declare type assertions that have identical behavior:
value as type(modern)<type>value(legacy, not supported in*.tsxfiles or witherasableSyntaxOnly)
The as operator was introduced in September 2015 in TypeScript 1.6 as the default way to cast in TSX files. The motivation was to remove ambiguity between JSX expressions and angle-bracket style of the type assertions.
Official documentation is relatively unopinionated about which to prefer in scenarios where either is viable, but some docs only show the as syntax. Third-party educators barely mention <prefix> assertions; Matt Pocock's materials mention them once to say "don't use this".
<prefix> type assertions are not allowed with erasableTypeSyntax. Node.js built-in support for type stripping only supports the as syntax.
The TypeScript-ESLint rule consistent-type-assertions defaults to preferring the as syntax and will error on <prefix> usage.
Opinion
Due to the greater compatibility, as well as engineer's preference for "give me one way to do it" consistency, the as syntax has been dominant for many years. I would speculate that most TypeScript users don't consciously know the old syntax exists. Either they don't come across it, or if they do they may casually overlook it and perhaps confuse it with some use of generics.
It would be constructive for TypeScript to build on the observed widespread preference and to set a clear direction for the future. This would decrease developer confusion and increase the compatibility of code in the wild.
Proposal
There is a graduated set of steps that could be taken, similar to that taken for the deprecated module keyword for namespace that reduced two-ways-to-do-it down to one. (I'll also highlight that deprecation was an excellent example of language stewardship, ecosystem cooperation, and forward-looking-yet-safe language evolution 💙)
There is value in beginning these steps, even if the process takes a long time, and even if not all steps are completed.
1. Discourage <prefix> assertions in docs
This would be a clear message to the ecosystem in the TypeScript documentation that one style is universally preferred over the other. It may inspire linters to take a stronger stance.
2. Soft-deprecate via Editor feedback
Use the LSP strikethrough ability to provide a visual indication of the legacy style within the IDE, along with a Quick Fix to convert the code to the modern style.
3. Warn in the checker
An error is emitted that can be silenced via "ignoreDeprecations". This represents formal deprecation.
4. Error in the checker
The final stage of deprecation.
Contributions
It would be very easy to find folk willing to contribute these changes if the core team preferred that.
FAQ
Will this disambiguate JSX? e.g. to safely allow JSX tags in regular *.ts files?
No. That's not the goal. There remain orthogonal issues blocking that.