Skip to content

feat(driverOptions): Allow to use global default_certificates_bundle_path as driverOptions #56873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
szaimen wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Draft

feat(driverOptions): Allow to use global default_certificates_bundle_path as driverOptions #56873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/private/DB/ConnectionFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,8 @@
//additional driver options, eg. for mysql ssl
$driverOptions = $this->config->getValue($configPrefix . 'dbdriveroptions', $this->config->getValue('dbdriveroptions', null));
if ($driverOptions) {
$rootCertPath = $driverOptions[PDO::MYSQL_ATTR_SSL_CA] ?? $this->config->getValue('default_certificates_bundle_path', null) ?? '';

Check failure on line 192 in lib/private/DB/ConnectionFactory.php

View workflow job for this annotation

GitHub Actions / static-code-analysis

UndefinedClass 

lib/private/DB/ConnectionFactory.php:192:35: UndefinedClass: Class, interface or enum named OC\DB\PDO does not exist (see https://psalm.dev/019)
Copy link
Member

@provokateurin provokateurin Dec 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use \OCP\ICertificateManager::getAbsoluteBundlePath instead.

$driverOptions[PDO::MYSQL_ATTR_SSL_CA] = $rootCertPath;

Check failure on line 193 in lib/private/DB/ConnectionFactory.php

View workflow job for this annotation

GitHub Actions / static-code-analysis

UndefinedClass 

lib/private/DB/ConnectionFactory.php:193:19: UndefinedClass: Class, interface or enum named OC\DB\PDO does not exist (see https://psalm.dev/019)
$connectionParams['driverOptions'] = $driverOptions;
}

Expand Down
Loading