Duplicate windows / multiple instances of one app support

[blauweb]

Hi,
It looks like the extension does not support multiple instances of one window/app.
Only one of the stored apps opens, despite the fact, that the json file does store the multiple instances.

The problem is with the recovery:
By analyzing the logs, it looks like the windows are being restored by their titles - if a window with a specific title is open, then another one wont open. When the session is being stored, the windows, depending on their content have different titles. But on restoration (reopening the windows), the title resets to their default (because certain apps launch with a default state), which causes the extensions to ignore the following instances, because they all have the same "title".
By the session json file, it does not seem like the windows have a unique ID assigned, which would imply, that they are being stored/restored based on their title, and this causes the issue I have described.

Related apps in the issue:

1. Terminal
2. Firefox

Please let me know, if I get it right, and if yes, would it be possible to include multiple instances of apps in the extension?

Environment:
Ubuntu 22.04
Gnome 42.9
Windowing System: X11

[carafelix]

Hi, I'm facing the same issue, any news?
I could work the feature, any relevant entry points to look at? @nlpsuge

[blauweb]

Not from my end. I am still using the extension, and have just found "peace" with the lack of this feature. I lack the knowledge and time, to work on it.

[krodelabestiole]

Related apps in the issue:

1. Terminal

2. Firefox

I guess Nautilus also meets this issue ? Unless I'm miss the point ? Also it won't recall the open directories...
(whereas VSCodium does retrieve its previous state, but I guess it comes from its inner session management...)

[carafelix]

I guess Nautilus also meets this issue ?

It happens to every app which you would like to open twice. My cheeky solution was to just open two different terminals (gnome-terminal, wrap) and do the same with browsers (firefox-like, chromium).

[brownbat]

Can confirm it hits multiple applications, including calculator, terminal, firefox, and others.

The problem seems to be that all windows from the same app are assigned the same ID with the following code:

gnome-shell-extension-another-window-session-manager/saveSession.js

Line 239 in 101b26f

sessionConfigObject.window_id = MetaWindowUtils.getStableWindowId(metaWindow);

and

gnome-shell-extension-another-window-session-manager/restoreSession.js

Line 189 in 101b26f

let desktop_file_id = session_config_object.desktop_file_id;

This leads to:

gnome-shell-extension-another-window-session-manager/restoreSession.js

Line 192 in 101b26f

const restoringShellAppData = restoreSessionObject.restoringApps.get(shell_app);

Where the restoration process skips over additional windows of the same app because they are all identified by the same shell_app key.

One potential solution could be to modify the shell_app key to include both the window position and the desktop file ID, ensuring that each window is uniquely identified and correctly restored.

[BienMeSabe]

Hi @nlpsuge, @blauweb, I found a workaround for this issue. Can you update your code?

Modify next lines in openWindowsTracker.js:

  Function _cleanUpSessionFileByWindow(window, sessionDirectory, sessionName):
    //FileUtils.removeFile(sessionFilePath);
    FileUtils.removeFileAndParent(sessionFilePath);
    //this._removeOrphanSessionConfigs(app, sessionDirectory);

  Function _cleanUpSessionFileByApp(app, appName, window, sessionDirectory):
    //this._log.debug(`${appName} was closed. Cleaning up its saved session files.`);
    //FileUtils.removeFile(sessionDirectory, true);

  Function _restoreWindowState(window):
    //this._log.warn(`${sessionFilePath} not found while restoring!`);
    this._log.debug(`${sessionFilePath} not found while restoring!`);

Modify next lines in restoreSession.js:

  Function launch(shellApp, desktopNumber):
    //if (this._restoredApps.has(shellApp)) {
        //this._log.info(`${shellApp.get_name()} is restored, skipping`);
        //return [true, false];
    //}

Modify next lines in saveSession.js:

  Function _builtSessionDetails(runningShellApp, metaWindow, cancellable = null):
    if (desktopAppInfo) {
    ...
    //} else {
    } else if (appName !== 'gjs') {

  Function _saveSessionConfigAsync(sessionConfig, baseDir = null, cancellable = null):
    //if (cancellable && cancellable.is_cancelled()) {
        //return Promise.resolve(false);
    //}
    if ((cancellable && cancellable.is_cancelled()) || (sessionConfig.app_name === 'gjs') || (sessionConfig.wm_class === undefined)) {
        return Promise.resolve(false);
    }
    ...
    //Log.Log.getDefault().info(`${savedMsg}`);
    Log.Log.getDefault().debug(`${savedMsg}`);

Modify next lines in ui/autoclose.js:

  Function :_overrideEndSessionDialog()
    //buttonInfo.label = (`${buttonInfo.label} (via AWSM)`);
    buttonInfo.label = (`${buttonInfo.label}`);

Now, it works as spected.