Divide and specialize hook impls/callers #634
Open
+883
−395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntations Divide hook abstractions into specialized types that encode behavior through class identity rather than runtime flags. This enables type-based dispatch via match statements instead of conditional branching on attributes. Hook callers now specialize by result handling strategy (list, first-result, historic). Hook implementations specialize by execution style (normal vs wrapper, new vs legacy wrapper). The _multicall function receives separate lists for normal and wrapper implementations, enabling cleaner dispatch logic. Backward compatibility maintained via HookCaller alias and legacy HookImpl. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Shift responsibility for argument extraction and wrapper setup/teardown from _multicall into the hook implementation classes themselves. The hookexec loop is now a simple iteration: - setup_teardown() on each wrapper (returns teardown callable) - call() on each normal impl - teardown(result, exception) returns (result, exception) Key changes: - Add _get_args() method to base _HookImplementation - Add call() method to _NormalHookImplementation - Add setup_teardown() method to _WrapperHookImplementation - Teardown returns tuple instead of raising exceptions - Result objects only created for legacy hookwrappers 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Update test_hook_and_wrappers_speed to use separate normal_impls and wrapper_impls lists with _create_hook_implementation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_NormalHookCaller,_FirstResultHookCaller,_HistoricHookCaller) and implementations (_NormalHookImplementation,_NewStyleWrapper,_OldStyleWrapper)_multicallloop becomes trivially simple:Test plan
🤖 Generated with Claude Code