Skip to content

Conversation

@radarhere
Copy link
Member

@radarhere radarhere commented Dec 5, 2025

#9318 upgraded zizmor to include https://docs.zizmor.sh/audits/#obfuscation

The CMD shell has no formal grammar, making it impossible to accurately analyze for security issues.

This PR allows for that by

  1. Changing test-windows.yml to avoid the cmd shell.
  2. Moving the cmd shell instructions from wheels.yml into a separate file, where they will not bother zizmor. It is not an ideal solution, but I suspect an ideal solution would involve changing winbuild to no longer generate cmd files, and that seems like a step too far. This will at least allow zizmor's rule to be in place, so that we can enforce it by default.

@radarhere radarhere changed the title Do not use cmd shell in Windows GitHub Actions Do not use cmd shell in GitHub Actions Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant