Skip to content

cocurrent bugs #38

@lwintermelon

Description

@lwintermelon

pg/disco/udp/udp.go

Lines 56 to 70 in 3b97d1c

func (c *UDPConn) Close() error {
c.upnpPortMapping.close()
close(c.closeChan)
c.udpConnsMutex.RLock()
for _, conn := range c.udpConns {
conn.Close()
}
c.udpConnsMutex.RUnlock()
c.closedWG.Wait()
close(c.natEvents)
close(c.datagrams)
close(c.endpoints)
close(c.errChan)
return nil
}

pg/disco/udp/udp.go

Lines 177 to 180 in 3b97d1c

select {
case c.natEvents <- &info:
default:
}

c.natEvents may be already closed, right?

For the dynamic added producer situation, I'm afraid WaitGroup is not enough.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions