[v8] Add "--strategy" parameter to "bind-service" command #3654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jochenehret
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Enhancement for rfc-0040-service-binding-rotation.
Add parameter
strategytobind-servicecommand. Allowed values aresingle(default) andmultiple. Withmultiple, the CLI sends and additional parameter"strategy": "multiple"to the CC v3 API:https://v3-apidocs.cloudfoundry.org/version/3.207.0/index.html#create-a-service-credential-binding
Why Is This PR Valuable?
This PR enhances the CLI so that the multiple service binding feature is enabled for end users. More PRs for other related commands will follow.
Applicable Issues
cloudfoundry/community#1198
How Urgent Is The Change?
Not super urgent.
Other Relevant Parties
Change is backwards compatible, so no regressions expected.