Deprecate dependencies checker/installer #1490
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I agree with this change; it’s indeed the user’s responsibility to install the required dependencies in their system or within a virtual environment (venv). Thanks @shelld3v for the work and detailed explanation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pkg_resourceswill soon be deprecated, and based on my research and testing,importlib.metadatais not a reliable replacement as under certain conditions, it might not be able to check installed dependencies probably, prevent users from running the tool. Therefore, the only solution is to remove this feature, the responsibility for installing dependencies should belong to the user, not dirsearchFix #1481, fix #1483