Use an atomic increment for nr_times_visited #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks Ben, appreciate the effort! This is of course a better implementation than what I did years back |
alextreme
approved these changes
Feb 11, 2025
Contributor
Author
|
I think some of this stuff didn't exist in Django back then. :-) Thanks for maintaining this app all these years! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update uses an update query with an F expression to atomically increment
nr_times_visited. The update query is run using totransaction.on_committo ensure that the value is only incremented when the current transaction succeeds (transaction.on_commitcalls the function immediately if there is no transaction).I also set
DEFAULT_AUTO_FIELDtoBigAutoFieldto silence the warning when running the tests.Feedback is appreciated. Feel free to also edit the PR if there are changes you want to make.