Don't default to AzureMFA #2549
Merged
+29
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h method is not, SqlLogin or Integrated or AzureMFA then return null as the AuthenticationType
Benjin
reviewed
Dec 5, 2025
src/Microsoft.SqlTools.ServiceLayer/Connection/ConnectionService.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.SqlTools.ServiceLayer/Connection/ConnectionService.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Be sure to update the unit tests; looks like those are failing the build |
Benjin
requested review from
aasimkhan30,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez,
llali,
manujoseph85 and
ssreerama
as code owners
aasimkhan30
approved these changes
Dec 6, 2025
aasimkhan30
deleted the
dev/allancascante/parse_connection_string_no_default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Auth should not default to Azure MFA, in particular when parsing a connection string using things like Authentication=Active Directory Service Principal
Code Changes Checklist
dotnet test)Reviewers: Please read our reviewer guidelines