-
Notifications
You must be signed in to change notification settings - Fork 961
feat(AuthForm): allow all input types #5565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commit: |
|
Would it instead be possible to reuse It might not make sense for all of them but I can certainly see using stuff like date when using the |
I think ui/src/runtime/components/Input.vue Line 23 in 8dc6b22
|
|
@benjamincanac Is there a reason why the input types are selectively picked or can we allow any input type? |
|
I think by default we only supported |
|
|
||
| - `name?: string`{lang="ts-type"} | ||
| - `type?: 'text' | 'password' | 'email' | 'number' | 'checkbox' | 'select' | 'otp'`{lang="ts-type"} | ||
| - `type?: 'text' | 'password' | 'email' | 'number' | 'tel' | 'checkbox' | 'select' | 'otp'`{lang="ts-type"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benjamincanac How will we handle supporting all input types in the docs? Do we list all of them or add something like InputHTMLAttributes['type']?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you can use | InputHTMLAttributes['type'] yes!
| - `name?: string`{lang="ts-type"} | ||
| - `type?: 'text' | 'password' | 'email' | 'number' | 'checkbox' | 'select' | 'otp'`{lang="ts-type"} | ||
| - `name: string`{lang="ts-type"} | ||
| - `type: 'checkbox' | 'select' | 'otp' | 'InputHTMLAttributes['type']'`{lang="ts-type"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the question marks because both props are required and the description below also stated that the type must be included.
|
This should be ready. |
benjamincanac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @J-Michalek! π
π Linked issue
Resolves #5564
β Type of change
π Description
The telephone field is often used in registration forms - makes sense to support it.
π Checklist