Skip to content

Conversation

@ropatil010
Copy link

As part of the https://issues.redhat.com/browse/CNTRLPLANE-2154 raised this PR which introduces a binary and supporting structure to enable the execution of run-once-duration-override-operator tests using the Open Test Environment (OTE).

Changes:

Remove test/tests-extension separate module infrastructure
Add cmd/run-once-duration-override-operator-tests-ext/main.go with OTE test registration
Update Dockerfile to build test binary with make build and gzip it
Update the README.md
Update go.mod, go.sum with required dependencies for ginkgo and openshift-tests-extension
Added vendor dependencies for new OTE framework
Please find the OTE test results.

{
"apiVersion": "v1.1",
"source": {
"commit": "",
"build_date": "",
"git_tree_state": ""
},
"component": {
"product": "openshift",
"type": "payload",
"name": "run-once-duration-override-operator"
},
"suites": null,
"images": null
}

/assign @wangke19 @gangwgr @zhouying7780
/hold

Rohit Patil and others added 2 commits December 5, 2025 20:54
- Created cmd/run-once-duration-override-operator-tests-ext/main.go with minimal template
  - Registers extension with OTE framework
  - No custom suite definitions or test spec manipulation
- Updated Dockerfile.rhel7 to use standard 'make build'
  - build-machinery-go automatically builds both binaries from cmd/
  - Added gzip and COPY for test binary
- Removed custom clean target from Makefile
  - build-machinery-go handles cleanup automatically
- Added OTE test documentation to README
  - Document building, running, and listing tests
  - Quick reference for OTE test framework
- Updated .gitignore for test binary

This moves to the simplified single-module architecture pattern where the test
binary is built alongside the operator binary using standard build machinery,
eliminating custom build targets and test suite configuration.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Added github.com/openshift-eng/openshift-tests-extension dependency
- Updated go.mod and go.sum
- Updated vendor/ directory

Co-Authored-By: ropatil <ropatil@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 5, 2025

@ropatil010: This pull request references CNTRLPLANE-2185 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

As part of the https://issues.redhat.com/browse/CNTRLPLANE-2154 raised this PR which introduces a binary and supporting structure to enable the execution of run-once-duration-override-operator tests using the Open Test Environment (OTE).

Changes:

Remove test/tests-extension separate module infrastructure
Add cmd/run-once-duration-override-operator-tests-ext/main.go with OTE test registration
Update Dockerfile to build test binary with make build and gzip it
Update the README.md
Update go.mod, go.sum with required dependencies for ginkgo and openshift-tests-extension
Added vendor dependencies for new OTE framework
Please find the OTE test results.

{
"apiVersion": "v1.1",
"source": {
"commit": "",
"build_date": "",
"git_tree_state": ""
},
"component": {
"product": "openshift",
"type": "payload",
"name": "run-once-duration-override-operator"
},
"suites": null,
"images": null
}

/assign @wangke19 @gangwgr @zhouying7780
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 5, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ropatil010
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2025

@ropatil010: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants