fix(semantic): add TS error code to constructor implementation missing diagnostic

[camc314]

No description provided.

[camc314]

• fix(semantic): add TS error code to function implementation missing diagnostic #16518
• fix(semantic): add TS error code to constructor implementation missing diagnostic #16517 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR adds the TypeScript error code TS(2390) to the "Constructor implementation is missing" diagnostic message, improving alignment with TypeScript's official error reporting format.

• Converts the diagnostic function from using OxcDiagnostic::error() to ts_error("2390", ...) helper
• Updates all 8 snapshot test occurrences to reflect the new error message format with the TS error code prefix

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_semantic/src/checker/typescript.rs	Modified constructor_implementation_missing function to use ts_error helper with error code "2390"
tasks/coverage/snapshots/parser_typescript.snap	Updated all 8 test snapshots to show the new error message format: × TS(2390): Constructor implementation is missing.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Add a doc comment to document the TypeScript error code, following the pattern used by other TS diagnostic functions in this file (e.g., line 217 /// TS(1392) and lines 233-234). This helps developers quickly identify which TypeScript error corresponds to this diagnostic.

Suggested addition:

/// TS(2390)
fn constructor_implementation_missing(span: Span) -> OxcDiagnostic {

Suggested change

	/// TS(2390)

[codspeed-hq]

CodSpeed Performance Report

Merging #16517 will not alter performance

_{Comparing c/12-04-fix_semantic_add_ts_error_code_to_constructor_implementation_missing_diagnostic (82848f3) with main (cfdfe7d)}

Summary

✅ 42 untouched
⏩ 3 skipped¹

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩