Skip to content

MAINT: Update skipped tests for sklearn1.8 #2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
david-cortes-intel wants to merge 6 commits into
base: main
Choose a base branch
from
Open

MAINT: Update skipped tests for sklearn1.8 #2788

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
22a8a4d
remove test that's no longer relevant
david-cortes-intel Nov 21, 2025
9be873a
clearer skip logic
david-cortes-intel Nov 24, 2025
0d27731
fix directionality of skips
david-cortes-intel Nov 26, 2025
90fced2
revert logic
david-cortes-intel Nov 26, 2025
9ce84e7
Merge branch 'main' into skip_outdated_nonlogistic_mnl
david-cortes-intel Nov 26, 2025
73a7733
Merge branch 'main' into skip_outdated_nonlogistic_mnl
david-cortes-intel Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_model_builders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2184,7 +2184,7 @@ def test_logreg_builder_sequential_calls():
),
]
if not sklearn_check_version("1.8")
else [(LogisticRegression(solver="liblinear"), 2)]
Copy link
Contributor

@avolkov-intel avolkov-intel Nov 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to remove this test, I think it's not deprecated

Copy link
Contributor Author

@david-cortes-intel david-cortes-intel Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is checking that it fails to convert the model. This would work fine.

else []
)
+ [
# case below might change in the future if sklearn improves their modules
Expand Down
Loading